Handle Checkbox ImageList scaling in Table in win32 #2801
Conversation
Test Results 118 files ±0 118 suites ±0 16m 40s ⏱️ - 1m 6s Results for commit 521d007. ± Comparison against base commit 28bb9b4. This pull request skips 2 tests.♻️ This comment has been updated with latest results. |
This commit handles scaling of ImageList in a table on DPI_CHANGE event by destroying the current imagelist and recalculating the height of the table item and then creating a new imagelist using the new size.
amartya4256
force-pushed
the
amartya4256/fix_tableItem_scaling
branch
from
b35bfd4 to
521d007
Compare
| long oldhImageList = OS.SendMessage(handle, OS.LVM_GETIMAGELIST, OS.LVSIL_SMALL, 0); | ||
| long hImageList = OS.ImageList_Create (1, 1, 0, 0, 0); | ||
| OS.SendMessage (handle, OS.LVM_SETIMAGELIST, OS.LVSIL_STATE, hImageList); | ||
| OS.SendMessage (handle, OS.LVM_SETIMAGELIST, OS.LVSIL_SMALL, hImageList); |
There was a problem hiding this comment.
cant we get the old image lists from the LVM_SETIMAGELIST instead of LVM_GETIMAGELIST?
| OS.SendMessage (handle, OS.LVM_SETIMAGELIST, OS.LVSIL_SMALL, hImageList); | |
| long hImageList = OS.ImageList_Create (1, 1, 0, 0, 0); | |
| long oldStateImageList = OS.SendMessage (handle, OS.LVM_SETIMAGELIST, OS.LVSIL_STATE, hImageList); | |
| long oldhImageList =OS.SendMessage (handle, OS.LVM_SETIMAGELIST, OS.LVSIL_SMALL, hImageList); |
| if((style & SWT.CHECK) != 0 ) { | ||
| destroyImageList(); | ||
| int size = getItemHeightInPixels(); | ||
| setCheckboxImageList(size, size, false); |
There was a problem hiding this comment.
@amartya4256 previously setCheckboxImageList was called with height and width of the icon and fixScroll true, why do we consider only the height now, is it because the checkbox is always square I see no visual regressions but just slightly confused why the height and width can be passed when setting checklbox ImageList, also why is fixscroll now false?
2 participants
This PR handles scaling of ImageList in a table on DPI_CHANGE event by destroying the current imagelist and recalculating the height of the table item and then creating a new imagelist using the new size.
How to test:
Before:
After:
